Skip to content

[lldb] Rework PCM validation disable for Swift #10974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kastiglione
Copy link

@kastiglione kastiglione commented Jul 9, 2025

The Preprocessor's options have changed to be const in llvm@277ab85. Since lldb can no longer mutate the options before constructing a clang importer, this change is to setup the options ahead of time.

@kastiglione kastiglione marked this pull request as ready for review July 9, 2025 22:01
@kastiglione kastiglione requested a review from JDevlieghere as a code owner July 9, 2025 22:01
@AnthonyLatsis
Copy link

@adrian-prantl ping

@kastiglione kastiglione force-pushed the dl/lldb-Rework-PCM-validation-disable-for-Swift branch from 2489889 to ada1a1b Compare July 29, 2025 17:24
@kastiglione kastiglione changed the base branch from stable/20250601 to stable/21.x July 29, 2025 17:24
@kastiglione kastiglione force-pushed the dl/lldb-Rework-PCM-validation-disable-for-Swift branch from ada1a1b to 07fca0a Compare July 29, 2025 17:25
@AnthonyLatsis
Copy link

@swift-ci please test macOS

@adrian-prantl
Copy link

I'm good with merging this.

@kastiglione kastiglione merged commit de06c52 into stable/21.x Jul 29, 2025
1 check was pending
@kastiglione kastiglione deleted the dl/lldb-Rework-PCM-validation-disable-for-Swift branch July 29, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants