Remove -index-store-path for clang vendor is not Apple #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlysingh
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
|
I think this looks reasonable, thanks! Let's see what we get out of the CI to indicate whether any tests need adjustment. |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
neonichu
reviewed
Feb 13, 2025
| } | ||
| commandLine = filteredCommandLine | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we just not add the flag in the first place based on vendor? Or is the idea that it would often come in via OTHER_*FLAGS?
There was a problem hiding this comment.
I agree that would be better. Should be able to do that by providing a lookup closure to commandLineFromOptions (near line 622) and overriding COMPILER_INDEX_STORE_ENABLE to NO.
There was a problem hiding this comment.
Sounds good. Working on it 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
This update removes -index-store-path when the Clang vendor is not Apple.
Feedback on the implementation would be greatly appreciated! Please note that I haven't tested this on Linux or within a Docker environment.
cc: @jakepetroules