Remove -index-store-path for clang vendor is not Apple #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlysingh
requested review from
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
Collaborator
|
@swift-ci test |
Collaborator
|
I think this looks reasonable, thanks! Let's see what we get out of the CI to indicate whether any tests need adjustment. |
Member
Author
|
@swift-ci test |
1 similar comment
Collaborator
|
@swift-ci test |
neonichu
reviewed
Feb 13, 2025
Collaborator
|
@swift-ci test |
Collaborator
|
@swift-ci test windows |
swiftlysingh
force-pushed
the
task/Compile-vendor-disable-if-not-apple-#24
branch
from
03ece4d to
48df948
Compare
Member
Author
|
I have rebased my branch with main to remove merge conflicts. Is there a way I can trigger tests? |
Collaborator
|
@swift-ci test |
neonichu
approved these changes
Mar 12, 2025
jakepetroules
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
This update removes -index-store-path when the Clang vendor is not Apple.
Feedback on the implementation would be greatly appreciated! Please note that I haven't tested this on Linux or within a Docker environment.
cc: @jakepetroules