Infer active Xcode for testing #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
owenv
as code owners
|
@swift-ci please test |
|
Ah I guess this breaks things outside of Xcode, so it needs to be a little more clever. |
neonichu
force-pushed
the
bbuegling/infer-active-xcode
branch
from
9d9523a to
01da188
Compare
|
@swift-ci please test |
|
Ah, of course that |
compnerd
reviewed
Feb 17, 2025
how about: if let versionInfo = versionInfo, (try? PropertyList.fromPath(versionInfo, fs: localFS))?.dictValue?["ProjectName"] == "IDEApplication" { |
Historically, we have been relying on `XCODE_DEVELOPER_DIR_PATH` being set to `DEVELOPER_DIR` in our schemes to find the active Xcode, but with auto-generated package schemes, this doesn't really work anymore. Try to infer the path from `PATH` instead which should be set when running in the context of Xcode.
neonichu
force-pushed
the
bbuegling/infer-active-xcode
branch
from
01da188 to
98972d6
Compare
|
@swift-ci please test |
jakepetroules
approved these changes
Feb 18, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, we have been relying on
XCODE_DEVELOPER_DIR_PATHbeing set toDEVELOPER_DIRin our schemes to find the active Xcode, but with auto-generated package schemes, this doesn't really work anymore. Try to infer the path fromPATHinstead which should be set when running in the context of Xcode.