Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix spelling errors in SWBCore documentation #208

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SWBCore/MacroConfigFileLoader.swift
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ final class MacroConfigFileLoader: Sendable {
return loadSettingsFromConfig(data: data, path: path, namespace: namespace, searchPaths: searchPaths, filesSignature: filesSignature)
}

/// Stores data about previosuly visited xcconfig files.
/// Stores data about previously visited xcconfig files.
fileprivate final class AncestorInclude {
let path: Path
let fs: any FSProxy
Expand Down
2 changes: 1 addition & 1 deletion Sources/SWBCore/MacroEvaluationExtensions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public extension PropertyListItem
let parsedString = scope.table.namespace.parseString(string)
let result = scope.evaluate(parsedString, lookup: preservingLookup)
if anyReferencesWerePreserved {
// If we preserved any refererences, then we need to convert the '\$\(((' in the result back to '$('.
// If we preserved any references, then we need to convert the '\$\(((' in the result back to '$('.
return result.replacingOccurrences(of: "\\$\\(((", with: "$(")
}
return result
Expand Down
2 changes: 1 addition & 1 deletion Sources/SWBCore/OptimizationRemarks.swift
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ extension Diagnostic {
public init?(_ remark: OptimizationRemark, workingDirectory: Path) {
guard let debugLoc = remark.debugLoc else { return nil } // skip if no debug location
let path = Path(debugLoc.sourceFilePath)
// Paths can be both asbolute and relative to the working directory.
// Paths can be both absolute and relative to the working directory.
let absolutePath = path.makeAbsolute(relativeTo: workingDirectory) ?? path
self.init(behavior: .remark, location: .path(absolutePath, line: Int(debugLoc.sourceLine), column: Int(debugLoc.sourceColumn)), data: DiagnosticData(remark.message))
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/SWBCore/PlatformRegistry.swift
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ public final class PlatformRegistry {
/// The list of all registered platforms, ordered by identifier.
public private(set) var platforms = Array<Platform>()

/// The map of platforms by identifer.
/// The map of platforms by identifier.
@_spi(Testing) public private(set) var platformsByIdentifier = Dictionary<String, Platform>()

/// The map of platforms by name.
Expand Down
2 changes: 1 addition & 1 deletion Sources/SWBCore/Provisioning.swift
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public func wrappedBundleIdentifier(for bundleIdentifier: String) -> String {
public func computeBundleIdentifier(from scope: MacroEvaluationScope, bundleIdentifierFromInfoPlist: MacroStringExpression) -> String {
let productBundleIdentifier = scope.evaluate(BuiltinMacros.PRODUCT_BUNDLE_IDENTIFIER)
if !productBundleIdentifier.isEmpty {
// When a test bundle is being signed **AND** that test bundle is being hosted in a test runner, then the bundle identifier should actualy match the test runner and **not** the test bundle.
// When a test bundle is being signed **AND** that test bundle is being hosted in a test runner, then the bundle identifier should actually match the test runner and **not** the test bundle.
if scope.evaluate(BuiltinMacros.USES_XCTRUNNER) {
return wrappedBundleIdentifier(for: productBundleIdentifier)
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/SWBCore/SDKRegistry.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1164,7 +1164,7 @@ public final class SDKRegistry: SDKRegistryLookup, CustomStringConvertible, Send
}

// Iterate through all of the SDKs looking for the best match.
// We sort the values by canoical name in reverse-lexicographic order solely to ensure determinism in any potential weird edge cases someone might accidentally stumble into that we haven't considered.
// We sort the values by canonical name in reverse-lexicographic order solely to ensure determinism in any potential weird edge cases someone might accidentally stumble into that we haven't considered.
var matchedSDK: (sdk: SDK, components: SDK.CanonicalNameComponents)? = nil
for candidateSDK in sdksByCanonicalName.values.sorted(by: { $0.canonicalName > $1.canonicalName }) {
// Get the components for the candidate SDK.
Expand Down
2 changes: 1 addition & 1 deletion Sources/SWBCore/SWBFeatureFlag.swift
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public enum SWBFeatureFlag {

public static let generatePrecompiledModulesReport = SWBFeatureFlagProperty("GeneratePrecompiledModulesReport", defaultValue: false)

/// Turn on llbuild's ownership analyis.
/// Turn on llbuild's ownership analysis.
/// Remove this feature flag after landing rdar://104894978 (Write "perform-ownership-analysis" = "yes" to build manifest by default)
public static let performOwnershipAnalysis = SWBFeatureFlagProperty("PerformOwnershipAnalysis", defaultValue: false)

Expand Down