Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typos in a bunch of variables #209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MojtabaHs
Copy link
Contributor

Two properties have been renamed. Both are scoped within functions, not called from outside, and are safe to merge. Please run the @swift-ci test to ensure everything works correctly.
Thanks!

Copy link
Collaborator

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swift-ci test

@jakepetroules jakepetroules enabled auto-merge (squash) February 22, 2025 20:09
@jakepetroules
Copy link
Collaborator

@swift-ci test

Copy link
Contributor

@mirza-garibovic mirza-garibovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the PR and commit wording to specify that it's a typo fix. Don't use generic titles like "fix" but specify what the nature of the problem is.

@MojtabaHs MojtabaHs changed the title fix: multiple properties in the SWBCore functions fix: correct typos in a bunch of variables Feb 23, 2025
@MojtabaHs
Copy link
Contributor Author

@mirza-garibovic I’m doing my best to follow the conventional commits guideline, and I’d really appreciate your input! If you have a specific name in mind, that would be super helpful—or if it’s easier, feel free to rename it yourself. Thanks a bunch!

@jakepetroules
Copy link
Collaborator

@swift-ci test Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants