Skip to content

Conversation

etcwilde
Copy link
Member

Adding the supported version ranges to each project. The newer versions of CMake have better support with some of the newer policies. Specifically CMP0157 in CMake 3.29 improves the incremental rebuild performance and hooks up the emissions of compile commands for Swift so that folks with Sourcekit-LSP can have a better editing experience.

@etcwilde etcwilde requested a review from compnerd April 29, 2024 22:51
Copy link

@lrineau lrineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. cmake_minimum_required with a range of versions is nicer than a set of cmake_policy with the policies set to NEW.

Adding the supported version ranges to each project. The newer versions
of CMake have better support with some of the newer policies.
Specifically CMP0157 in CMake 3.29 improves the incremental rebuild
performance and hooks up the emissions of compile commands for Swift so
that folks with Sourcekit-LSP can have a better editing experience.
@etcwilde etcwilde force-pushed the ewilde/update-cmake-versions branch from 73b2369 to d94cde8 Compare April 25, 2025 20:23
@etcwilde etcwilde merged commit dc756e5 into swiftlang:main Apr 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants