CMake 4.0.1 fixes #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 4.0 does not specify CMAKE_OSX_SYSROOT unless it is set explicitly. When this is the case, passing the `-sdk` flag with an empty path confuses the compiler and results in build failures. This patch fixes things to only pass the sdk to the Swift compiler when the SDK is actually set.
Adding CMake 4.0.1, the most recent CMake release, to the set of tested CMake versions.
compnerd
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 4.0 and newer does not set
CMAKE_OSX_SYSROOTby default. We should only explicitly pass an SDK when there is an SDK to pass.Also adding CMake 4.0.1 to the set of CMake versions to test.
Fixes: #18