Skip to content

Conversation

AZero13
Copy link
Contributor

@AZero13 AZero13 commented Dec 11, 2024

No description provided.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By that token, the type should be size_t as sizeof(...) / sizeof(...) is a size_t as sizeof returns size_t. I'm not sure that there is a good justification here per se. Why not convert the int to CFIndex at the use site?

@AZero13
Copy link
Contributor Author

AZero13 commented Dec 11, 2024

By that token, the type should be size_t as sizeof(...) / sizeof(...) is a size_t as sizeof returns size_t. I'm not sure that there is a good justification here per se. Why not convert the int to CFIndex at the use site?

Because it fits in a CFIndex and long means more possible optimizations due to unsigned being defined overflow behavior even if it doesn't overflow (thanks LLVM)

@compnerd
Copy link
Member

compnerd commented May 5, 2025

Are all of these paths currently exercised? The current migration from swift-corelibs-foundation to swift-foundation means that much of CoreFoundation is unused.

@parkera
Copy link
Contributor

parkera commented May 5, 2025

@swift-ci test

@parkera
Copy link
Contributor

parkera commented May 5, 2025

I've been trying to delete CF code that is truly unused as we go. Even if I missed some, it seems fine to take this patch to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants