Skip to content

Conversation

3405691582
Copy link
Member

Unwind some conditionals hiding makeProcessSource and associated DispatchSourceProcess.

We can probably makeFileSystemObjectSource too, but presumably since pid_t on OpenBSD is Int32, there is a protocol conflict with DispatchSourceProcess and DispatchSourceFileSystemObject. For now, just reveal DispatchSourceProcess.

Unwind some conditionals hiding makeProcessSource and associated
DispatchSourceProcess.

We can probably makeFileSystemObjectSource too, but presumably since
pid_t on OpenBSD is Int32, there is a protocol conflict with
DispatchSourceProcess and DispatchSourceFileSystemObject. For now, just
reveal DispatchSourceProcess.
@3405691582
Copy link
Member Author

cc @jakepetroules

Copy link
Contributor

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm thinking we can use this in Swift Subprocess without having to manually implement the kqueue logic.

@jakepetroules
Copy link
Contributor

@swift-ci test

@compnerd
Copy link
Member

@swift-ci please test Windows platform

1 similar comment
@3405691582
Copy link
Member Author

@swift-ci please test Windows platform

@3405691582
Copy link
Member Author

@swift-ci please test Windows platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants