-
Notifications
You must be signed in to change notification settings - Fork 24
Add support for generating Swift SDKs with multiple host triples #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MaxDesiatov
merged 1 commit into
swiftlang:main
from
jakepetroules:eng/PR-multiple-host-triples
Sep 1, 2025
Merged
Add support for generating Swift SDKs with multiple host triples #232
MaxDesiatov
merged 1 commit into
swiftlang:main
from
jakepetroules:eng/PR-multiple-host-triples
Sep 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0f1892 to
f7c60ef
Compare
|
@swift-ci test |
MaxDesiatov
reviewed
Aug 13, 2025
Sources/SwiftSDKGenerator/Artifacts/DownloadableArtifacts.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Aug 13, 2025
Tests/SwiftSDKGeneratorTests/SwiftSDKRecipes/LinuxRecipeTests.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Aug 13, 2025
da2e479 to
38e7165
Compare
|
@swift-ci test |
MaxDesiatov
reviewed
Aug 29, 2025
Sources/SwiftSDKGenerator/Artifacts/DownloadableArtifacts.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Aug 29, 2025
Tests/SwiftSDKGeneratorTests/SwiftSDKRecipes/LinuxRecipeTests.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Aug 29, 2025
MaxDesiatov
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM modulo nits for line length and a clarifying doc comment
c544da0 to
4691ac7
Compare
|
@swift-ci test |
This is necessary for correctness on macOS, where the concept of multi-arch binaries exists, and all swift.org toolchains for macOS are multi-arch.
4691ac7 to
e4f9e54
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for correctness on macOS, where the concept of multi-arch binaries exists, and all swift.org toolchains for macOS are multi-arch.