FreeBSD improvements and bug fixes #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain enum cases, such as `freeBSD`, contain capital letters. However, target triples must be entirely in lower case. The enum case's raw value reflects this, but our custom initializer for the Triple structure does not use it, resulting in an invalid target triple. This makes the generated SDK unusable if the user passed only the desired architecture instead of a complete triple. To address this problem, the initializer should always request the rawValue explicitly.
Target triples for the FreeBSD platform must include the FreeBSD version number at the end of the triple. If we use a derived target triple, then the version number won't be included, resulting in the SDK not being usable.
CodingCarpincho
force-pushed
the
freebsd-improvements
branch
from
b0bb8bf to
b0c10e1
Compare
|
@swift-ci test |
MaxDesiatov
reviewed
Sep 8, 2025
MaxDesiatov
reviewed
Sep 8, 2025
MaxDesiatov
reviewed
Sep 8, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rawValuewhen using OS enum as stringCC @jakepetroules @MaxDesiatov