Skip to content

Conversation

@euanh
Copy link
Contributor

@euanh euanh commented Sep 25, 2025

No description provided.

@euanh euanh requested a review from MaxDesiatov as a code owner September 25, 2025 13:27
@euanh
Copy link
Contributor Author

euanh commented Sep 25, 2025

@swift-ci test

@xtremekforever
Copy link
Contributor

Easy enough, however do you want to add 6.2 to the E2E matrix?

@MaxDesiatov
Copy link
Contributor

I concur, this deserves to include an addition to Tests/SwiftSDKGeneratorTests/EndToEndTests.swift

@Joannis
Copy link
Member

Joannis commented Nov 5, 2025

@euanh did you see the above comments?

@euanh
Copy link
Contributor Author

euanh commented Nov 5, 2025

@swift-ci test

@euanh
Copy link
Contributor Author

euanh commented Nov 5, 2025

@swift-ci test

@euanh
Copy link
Contributor Author

euanh commented Nov 6, 2025

Thanks @Joannis

@MaxDesiatov I've updated the tests. There's a lot of duplication now and we should try to reduce it.

  • In Bump swift-tools-version to 6.0 #237 you mentioned that we're no longer directly testing 5.9 and 5.10: shall we drop the end to end tests for those versions as well?
  • If we merge Bump swift-tools-version to 6.0 #237, we should translate the end to end tests to swift-testing parameterised tests.
    I'd prefer to merge this PR as-is and make those changes in their own PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants