Organize discovered tests in a runner plan based on the module they're implemented in #1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e implemented in rdar://147356925
stmontgomery
added
bug
grynspan
reviewed
May 27, 2025
| /// property on the ID of the containing suite will be the name of the | ||
| /// imported module, but the value of this property for the ID of the test | ||
| /// within that extension will be the name of the module which declares the | ||
| /// extension. |
There was a problem hiding this comment.
Danger! This is potentially ambiguous. We may want to instead describe such a test in terms of both modules.
grynspan
reviewed
May 27, 2025
| @@ -123,6 +131,8 @@ extension Test: Identifiable { | |||
| var result = containingTypeInfo.map(ID.init) | |||
| ?? ID(moduleName: sourceLocation.moduleName, nameComponents: [], sourceLocation: nil) | |||
|
|
|||
| result.moduleName = sourceLocation.moduleName | |||
There was a problem hiding this comment.
How about we store this value in a separate field (if it differs from the inferred module)? extensionModuleName: String? perhaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Checklist:
rdar://147356925