Remove FreeBSD version from swiftmodule triple #79103
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
approved these changes
Feb 2, 2025
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
This seems fine for FreeBSD. I kicked off Windows CI again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include FreeBSD version in the swift sdk triple. This makes swiftlang/swift-build#12 easier.
Although technically different versions of FreeBSD does not guarantee ABI stability across major versionsFreeBSD guarantees user land ABI stability across major version, toolchain are shipping per OS version anyway, so it shouldn't affect user in any meaningful way. (each major release will likely have a separate toolchain).This also have the additional benefit that the swift toolchain will not break and complain about not finding the correct swiftmodule across minor updates (which ABI stability is preserved across)