[ClangImporter] Refactor swiftify decl (NFC) #85103
Merged
+498
−457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pure refactor to make it easier to follow the upcoming addition of swiftifyProtocol.
hnrklssn
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
|
@swift-ci please smoke test |
This will make it more straightforward to later templatize it.
This code doesn't interact that much with the rest of ClangImporter, and will continue to grow. Keeping it in a separate file makes it easier to navigate.
hnrklssn
force-pushed
the
refactor-swiftify-decl
branch
from
a156288 to
e0f6a44
Compare
|
@swift-ci please smoke test |
Now that swiftify related functions have their own file there's no need to use DEBUG_WITH_TYPE explicitly anymore.
hnrklssn
force-pushed
the
refactor-swiftify-decl
branch
from
e0f6a44 to
722afef
Compare
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are pure refactors in preparation for adding
@_SwiftifyImportProtocolsupport to ClangImporter.The core of
swiftify()is extracted toswiftifyImpl(), and they (along with accompanying helpers) are both moved to the new filelib/ClangImporter/SwiftifyDecl.cpp.