phpstan-strict-rules

swissspidy · Oct 9, 2024 · 16f32b7 · 16f32b7
1 parent 74edd1e
commit 16f32b7
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 7 deletions.
diff --git a/composer.json b/composer.json
@@ -11,8 +11,9 @@
 	},
 	"require-dev": {
 		"dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
-		"php-parallel-lint/php-parallel-lint": "^1.2",
+		"php-parallel-lint/php-parallel-lint": "^1.4",
 		"phpstan/phpstan-phpunit": "^2.0",
+		"phpstan/phpstan-strict-rules": "^2.0",
 		"phpunit/phpunit": "^9.5",
 		"slevomat/coding-standard": "^8.8.0",
 		"squizlabs/php_codesniffer": "^3.5.3"

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,6 +1,7 @@
 includes:
 	- rules.neon
 	- vendor/phpstan/phpstan/conf/bleedingEdge.neon
+	- vendor/phpstan/phpstan-strict-rules/rules.neon
 	- vendor/phpstan/phpstan-phpunit/extension.neon
 
 parameters:

diff --git a/src/Rules/NoPrivate/CallToPrivateFunctionRule.php b/src/Rules/NoPrivate/CallToPrivateFunctionRule.php
@@ -51,7 +51,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$docComment = $function->getDocComment();
 
-		if (!$docComment) {
+		if ($docComment === null) {
 			return [];
 		}
 

diff --git a/src/Rules/NoPrivate/CallToPrivateMethodRule.php b/src/Rules/NoPrivate/CallToPrivateMethodRule.php
@@ -58,7 +58,7 @@ public function processNode(Node $node, Scope $scope): array
 
 				$docComment = $methodReflection->getDocComment();
 
-				if (!$docComment) {
+				if ($docComment === null) {
 					continue;
 				}
 

diff --git a/src/Rules/NoPrivate/CallToPrivateStaticMethodRule.php b/src/Rules/NoPrivate/CallToPrivateStaticMethodRule.php
@@ -90,7 +90,7 @@ static function (Type $type) use ($methodName): bool {
 			}
 
 			$resolvedPhpDoc = $class->getResolvedPhpDoc();
-			if ($resolvedPhpDoc && PrivateAnnotationHelper::isPrivate($resolvedPhpDoc)) {
+			if ($resolvedPhpDoc !== null && PrivateAnnotationHelper::isPrivate($resolvedPhpDoc)) {
 				$errors[] = RuleErrorBuilder::message(
 					sprintf(
 						'Call to method %s() of private/internal class %s.',
@@ -105,7 +105,7 @@ static function (Type $type) use ($methodName): bool {
 
 			$docComment = $methodReflection->getDocComment();
 
-			if (!$docComment) {
+			if ($docComment === null) {
 				continue;
 			}
 

diff --git a/src/Rules/NoPrivate/InheritanceOfPrivateClassRule.php b/src/Rules/NoPrivate/InheritanceOfPrivateClassRule.php
@@ -53,7 +53,7 @@ public function processNode(Node $node, Scope $scope): array
 		try {
 			$parentClass = $this->reflectionProvider->getClass($parentClassName);
 			$resolvedPhpDoc = $parentClass->getResolvedPhpDoc();
-			if (!$resolvedPhpDoc || !PrivateAnnotationHelper::isPrivate($resolvedPhpDoc)) {
+			if ($resolvedPhpDoc === null || !PrivateAnnotationHelper::isPrivate($resolvedPhpDoc)) {
 				return $errors;
 			}
 

diff --git a/src/Rules/NoPrivate/InstantiationOfPrivateClassRule.php b/src/Rules/NoPrivate/InstantiationOfPrivateClassRule.php
@@ -77,7 +77,7 @@ static function (): bool {
 			}
 
 			$resolvedPhpDoc = $class->getResolvedPhpDoc();
-			if (!$resolvedPhpDoc || !PrivateAnnotationHelper::isPrivate($resolvedPhpDoc)) {
+			if ($resolvedPhpDoc === null || !PrivateAnnotationHelper::isPrivate($resolvedPhpDoc)) {
 				continue;
 			}