Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search bar opening issue when shortcut key is pressed #220

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

happer64bit
Copy link
Contributor

Description

Fixed an issue where using shortcut keys on the website would open both the search bar on the site and the browser's search.

Checks

  • [ x] The PR is submitted to the main branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

Additional information

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for splendorous-kataifi-9ae281 ready!

Name Link
🔨 Latest commit 7eb3dea
🔍 Latest deploy log https://app.netlify.com/sites/splendorous-kataifi-9ae281/deploys/67c5ed61fdab580008e63ee6
😎 Deploy Preview https://deploy-preview-220--splendorous-kataifi-9ae281.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hirasso
Copy link
Member

hirasso commented Mar 6, 2025

Hello @happer64bit and thank you for your contribution!

Which combination is opening the browser's search bar on your machine? K or /? Neither opens the browser search on my machine – that's F on my end (German keyboard, English OS).

@happer64bit
Copy link
Contributor Author

happer64bit commented Mar 8, 2025

@hirasso it's and K or\. It works well on my machine. You can try it out on preview deployment.

@hirasso
Copy link
Member

hirasso commented Mar 8, 2025

What do you mean by "it works well"? It's also working fine on my machine, regardless of the proposed change in this PR.

A short screencast of before/after would help. Can you create one and upload it here?

We need to know exactly what problem we are actually solving before we can merge this.

@happer64bit
Copy link
Contributor Author

The shortcut key conflicts with an existing shortcut in Chrome and other browsers (Edge, Brave). When we try to open the search bar using Ctrl + K, both the browser's search bar and the website's search bar appear simultaneously

Here is the comparison.

2025-03-08.21-07-10.mp4

@hirasso
Copy link
Member

hirasso commented Mar 8, 2025

Thank you for the screen cast! Again learned something new :)

@hirasso hirasso merged commit 0817730 into swup:master Mar 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants