fix: normalize BYOK responses usage - #20
Merged
Merged
Conversation
jomangbp
pushed a commit
to jomangbp/codex-shim
that referenced
this pull request
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input_tokens,output_tokens, andtotal_tokensfor BYOK routes.input_tokens_details/output_tokens_detailswhen upstreams provide them.message_start.usageso stream cache usage is not dropped.codedb.snapshotinspection artifacts.Why this matters
Some OpenAI-compatible BYOK providers return Chat-style usage (
prompt_tokens/completion_tokens). Codex expects Responses-style usage onresponse.completed; when the shape is wrong, a successful model response can still make Codex reject the turn and retry the request. This fix keeps BYOK agent loops usable and preserves token/cache accounting for compaction and cost visibility.Verification
python3 -m pytest tests/ -qpython3 -m compileall codex_shim/ -qcodex-cli 0.134.0throughcodex-shimtomimo-v2.5-pro: turn completed successfully with cache usage reported (input_tokens: 25728,cached_input_tokens: 25664).Security review
Diff-scoped
codex-securityreview completed. No exploitable issue found in the changed code path.