[CI/CD] Smoke-test the packaged desktop launch, health, and native bridge by fettpl · Pull Request #251 · sybil-solutions/local-studio

fettpl · 2026-07-18T17:53:00Z

Summary

Add a bounded production-bundle smoke test that launches the actual unpacked Electron app in isolated state.
Verify the embedded frontend health endpoint and packaged preload/native PTY bridge.
Fail closed on unsafe inherited process settings, bound diagnostics, and clean the complete process tree and temporary state on every path.
Install controller contracts on clean CI runners before the desktop smoke job and keep release publication dependent on that job.

Closes #232

Design

This branch is stacked on #244 and #248 and should merge after them. The smoke harness uses a scrubbed environment, isolated user data, one abortable lifecycle deadline, exact architecture checks, bounded redacted diagnostics, ownership-aware cleanup, and deadline-bounded preload readiness polling. The release workflow cannot publish until the packaged desktop smoke succeeds for the tested revision.

Validation

Exact reviewed head: 353b789ab5b8ba0e0bd53a821fc032aa61043bdf.
Independent P0/P1 review: approved with no blockers.
Desktop smoke unit suite: 47/47 passed.
Workflow-policy suite: 74/74 passed.
npm --prefix frontend run check:quality: passed.
npm run check: passed.
npm --prefix frontend run test: passed.
npm run test:integration: passed.
Clean npm --prefix frontend ci --legacy-peer-deps --install-links: passed and materialized local package dependencies inside the frontend package boundary.
npm --prefix frontend run desktop:smoke:pack: passed.
Three consecutive npm --prefix frontend run desktop:smoke launches passed with health=200 and nativePty=true.
npm --prefix frontend run desktop:dist: passed and produced DMG, ZIP, and unpacked app artifacts; signing was skipped because no valid signing identity was available.
The exact build was installed at /Applications/Local Studio.app; GET /api/desktop-health returned HTTP 200 with ok: true.
Normal pre-push frontend quality/build hook: passed.
Exact-head GitHub CI and Security runs are action_required with zero executable jobs, pending upstream workflow approval; no genuine CI failure is present.

UI changes

None. This adds packaging, CI, and launch-health coverage only.

Risks and rollout

Merge [CI/CD] Gate every release on the exact commit that passed CI #244 and [CI/CD] Make the CI and release toolchain immutable and reproducible #248 first.
The smoke runs on the macOS packaging runner and is a required exact-revision release dependency.
It verifies native PTY availability through the existing preload status bridge and never opens a terminal command.
Controller credentials and runtime overrides are removed from the child environment; retained diagnostics are sanitized and bounded.

…e guard - navigate-to-session: the window.location.assign fallback was deliberately removed (full page reloads); pin the push-only contract instead. - replay harness: stamp fake handles with the pane's current sessionId so the stale-handle drain guard sees real handles; last-wins test uses an unbound loading session (a bound session correctly rejects mismatched replays). - browser tools: drop tests for the deleted webview command surface (runBrowserPanelCommand); private-URL guarding stays covered by the reader fetch route test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…gation Terminals were second-class panes: they never appeared in the sidebar, never pushed a URL, and any session navigation (including browser Back) overwrote the sole terminal pane with a chat — the PTY stayed alive in the Electron main process but nothing referenced its mountKey anymore. - Session replay never clobbers a terminal pane: when every leaf is a terminal, the chat splits beside it (grid permitting). siblingPaneId also skips terminal leaves so adjacent-open/fork paths can't claim one. - Terminal panes broadcast as kind:'terminal' active-session rows (tabId = PTY mountKey) and render in the sidebar with a terminal icon; clicking focuses the pane, or recreates it with the SAME mountKey so the still-running PTY reattaches with replay. Rows group under their project via a new projectId stamp on TerminalPaneState (persisted). - /agent?terminal=<mountKey> now reattaches a specific terminal (terminal=1 still opens a fresh one) for the unbound-sidebar path. - Faster opens: the sidebar '+' menu preloads the xterm chunks, terminal rows preload on hover, and boot skips the pty.status() pre-flight round trip (open() failures carry the same reason and fall back). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Entering /agent blocked the sidebar AND any ?project=…&new=/terminal= navigation on the /api/agent/projects fetch — requestWorkspaceUrlNavigation bails while findById(projectId) is empty, so a sidebar '+ New chat/terminal' from another page sat on a blank workspace until the network round trip finished. Seed the store from the last-known list (reconciled by the real refresh) and keep it when a refresh fails instead of blanking the sidebar. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Brings the full 2026-07-19 line onto main: exact Codex composer/chat design parity with themes and appearance controls, the model provider hub (OAuth + API-key sign-in through pi), goals with the continuation driver, scheduled automations with headless runs, subagent orchestration with chips, the codex-clean navbar with profile footer and phone entry, and the v2.1.0 release prep. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

rigs.ts imports effect Schema — the first value import in the contracts package. Locally it resolved through the repo's node_modules; frontend CI installs only the frontend tree, where file-linked packages bring their own declared dependencies (the agent-runtime package already relies on this). Declare effect so the production quality gate resolves it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…turn dispatch (sybil-solutions#261) * feat(agent): add secure Litter bridge contract * feat(agent): add secure Litter controller gateway * fix(desktop): repair standalone dependency links * fix(desktop): share the live projects registry * feat(agent-runtime): export canonical litter sessions * fix(desktop): restore agent controls and layout * feat: refine agent drawers and profile controls * feat: move profile pairing into settings * feat(agent-runtime): add signed session discovery * fix(agent-runtime): narrow snapshot capability claims * fix(agent-runtime): bind litter mutation idempotency * fix(agent-runtime): authenticate litter controller snapshots * fix(agent-runtime): mark missing litter sections stale * feat(agent-runtime): define litter turn acknowledgements * feat(agent-runtime): persist litter mutation reservations * feat(agent-runtime): expose prompt preflight controls * feat(agent-runtime): dispatch signed litter prompts * test(agent-runtime): cover litter ledger failures * fix(agent-runtime): make litter turns crash durable * feat(studio): improve model picks and agent sessions * fix(usage): show proxied activity only * feat(agent): refine goal composer * feat(studio): refine model catalog and goal composer * feat(desktop): copy KittyLitter pairing JSON * fix(studio): align composer controls and catalog * fix(settings): support controller pairing QR codes * fix(desktop): copy pairing JSON through Electron * fix(proxy): stop withholding streamed content for engine-parsed reasoning models * fix(desktop): grant sanitized clipboard writes to the app main frame * feat(settings): guide KittyLitter beta pairing * fix(agent-runtime): harden litter turn recovery and release gates * fix(agent-runtime): clarify reconcile conflicts and pin release gates * ci(agent-runtime): link root modules for shared imports * build(shared): declare effect dependency for contract package * fix(desktop): tolerate cold-start pairing latency * fix(desktop): retry cold-start pairing with effect schedule * feat(settings): add pairing retry action * fix(settings): keep primary link text visible * feat(agent): make workbench Pi-native * feat(agent): gate non-controller models * feat(composer): chatgpt-style project drawer, drop tool-access toggle, responsive actions * feat(ops): stage glm52 vision graft * fix(composer): reset drawer goal state across session switches * fix(agent): restore session switching * fix(files): restore syntax highlighting

Restore cached Pi session titles during persisted workbench hydration and add regression coverage.

0xSero · 2026-08-04T08:54:23Z

Closing as superseded. Current desktop-package CI already runs the packaged smoke surface before exact-SHA release; the latest main job passed.

0xSero and others added 30 commits July 8, 2026 11:10

fix: register xml grammar so html files highlight

10524ca

fix: open sidebar sessions in place instead of hard page reloads

1d63131

feat: infer model family avatars for local recipe ids

00c8d74

fix: drop stale replay drains when a pane swaps sessions

40cdb7e

test: guard replay queue against stale pane handles

52e332f

fix: fall back through avatar owner candidates for local model paths

9ac7633

test: align terminal pane navigation tests with chat isolation

7192e00

fix: speed up desktop terminal startup

27d8059

fix: open chat rows without terminal panes

035b5ae

perf: defer agent shell work on app pages

0c29da9

perf: lazy load markdown-heavy UI

415abd3

perf: split shared UI boot code

d0e24ca

perf: defer agent timeline renderer

7421066

perf: delay sidebar session hydration

8bc4cc8

perf: remove page-load agent and proxy drag

8e7afa1

perf: stop sidebar prefetch and duplicate dashboard recipes

9afa4e2

fix: keep terminal panes out of chat session lists

8a88406

perf: defer agent tool effects from root app

3b99d11

test: add frontend perf budget audit

4b424d1

fix: release test commits as patches

d7df212

test: add browser perf budget audit

32a31ea

fix: keep past sessions single-pane

7ef949e

test: discover routes in performance audits

2793333

feat: add landing and setup pages

3452b2a

docs: preserve serve pipeline design baseline

b58a511

refactor: make serve runtime explicit

97d18b5

refactor: launch vllm from serve runtime

425cf03

0xSero and others added 3 commits July 19, 2026 18:33

fix(ci): install shared contract dependencies

08bcba2

fettpl force-pushed the p1/issue-232-desktop-package-smoke branch from 76f25c3 to 0a521bf Compare July 20, 2026 08:59

0xSero and others added 21 commits July 23, 2026 00:10

fix(agent): preserve session metadata across reloads

6577cbf

Restore cached Pi session titles during persisted workbench hydration and add regression coverage.

ci: gate releases on validated commits

e0f35fa

fix(ci): require agent runtime before release

1ca72be

fix(ci): validate only pushed branch commits

48ce95d

test(ci): isolate pre-push fixture config

b9fc037

fix(ci): exclude tracked remote commits before push

895d388

fix(ci): limit push exclusions to default branches

0071250

test(ci): isolate fixture from hook environment

b716910

ci: pin workflow toolchain dependencies

d4fda2f

fix: align workflow pinning with current build

6af25f6

fix(ci): preserve tested release revisions

a0a903a

test(ci): verify pinned release workflow

7ee43e4

fix(ci): align pinning with refreshed main

d58a6aa

test(ci): include agent runtime in release graph

e37f746

ci: smoke-test packaged desktop runtime

04a271f

fix(ci): install desktop smoke dependencies

b1e19a5

test(ci): require desktop smoke before release

0246a24

fix(ci): preserve developer desktop packaging

11b6f02

fix(ci): materialize desktop smoke dependencies

809f856

fix(ci): wait for desktop preload readiness

353b789

fettpl force-pushed the p1/issue-232-desktop-package-smoke branch from 0a521bf to 353b789 Compare July 23, 2026 10:17

0xSero force-pushed the main branch from 8ab4e9a to 0c3c7c8 Compare July 26, 2026 09:47

0xSero closed this Aug 4, 2026

fettpl deleted the p1/issue-232-desktop-package-smoke branch August 7, 2026 18:01

Navigation Menu

Uh oh!

[CI/CD] Smoke-test the packaged desktop launch, health, and native bridge - #251

[CI/CD] Smoke-test the packaged desktop launch, health, and native bridge#251
fettpl wants to merge 1323 commits into
sybil-solutions:mainfrom
fettpl:p1/issue-232-desktop-package-smoke

fettpl commented Jul 18, 2026 •

edited

Loading

Uh oh!

0xSero commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

fettpl commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Design

Validation

UI changes

Risks and rollout

Uh oh!

0xSero commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fettpl commented Jul 18, 2026 •

edited

Loading