#26 Allow to download schema from http(s) #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilx
reviewed
Dec 18, 2021
src/main/java/com/github/sylvainlaurent/maven/yamljsonvalidator/ValidateMojo.java
Outdated
Show resolved
Hide resolved
|
@wilx Could you accept this pull request ? |
wilx
approved these changes
Dec 28, 2021
|
Thank you @wilx |
|
Can anybody merge this PR ? |
matefoldes
suggested changes
Mar 4, 2022
| import java.io.FileInputStream; | ||
| import java.io.FileNotFoundException; | ||
| import java.io.InputStream; | ||
| import java.io.*; |
There was a problem hiding this comment.
Please don't use wildcard imports.
You can read more about it here: https://stackoverflow.com/questions/147454/why-is-using-a-wild-card-with-a-java-import-statement-bad
| InputStream inputStream = this.getClass().getClassLoader().getResourceAsStream(jsonSchemaFile); | ||
| if (inputStream != null) { | ||
| return inputStream; | ||
| try { |
There was a problem hiding this comment.
Could you split up these into multiple, smaller methods? It's quite hard to read it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simply added the ability to download schemas from http using apache's HttpClient. This HttpClient can be configured using the system properties so it is possible to configure SSL, proxies, etc. this way.
I also added unit and integration tests.