Skip to content

[tools/shoestring]: Fix ca.pubkey.pem not updated when renewing CA certificate#1590

Open
ccHarvestasya wants to merge 4 commits intosymbol:devfrom
ccHarvestasya:shoestring/fix_renew-ca-pubkey-update
Open

[tools/shoestring]: Fix ca.pubkey.pem not updated when renewing CA certificate#1590
ccHarvestasya wants to merge 4 commits intosymbol:devfrom
ccHarvestasya:shoestring/fix_renew-ca-pubkey-update

Conversation

@ccHarvestasya
Copy link
Contributor

Summary

This PR fixes an issue where ca.pubkey.pem was not updated when running renew-certificates --renew-ca.

Problem

  • Renewing the CA certificate with --renew-ca replaced the CA certificate, but the corresponding ca.pubkey.pem file remained outdated.
  • This could cause inconsistencies between the new CA certificate and the public key file.

Fix

  • Ensure that ca.pubkey.pem is regenerated whenever the CA certificate is renewed with --renew-ca.

Impact

  • Prevents nodes from starting with an outdated CA certificate.
  • Ensures ca.pubkey.pem is always regenerated alongside the renewed CA certificate.
  • Improves security and consistency of certificate management.

@ccHarvestasya ccHarvestasya changed the title Fix ca.pubkey.pem not updated when renewing CA certificate [tools/shoestring]: Fix ca.pubkey.pem not updated when renewing CA certificate Sep 7, 2025
@Jaguar0625 Jaguar0625 force-pushed the dev branch 2 times, most recently from f18d312 to 3a736e0 Compare October 1, 2025 21:44
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (e4db30c) to head (97136e9).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1590   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         259      259           
  Lines       17821    17822    +1     
  Branches      215      215           
=======================================
+ Hits        17236    17237    +1     
  Misses        579      579           
  Partials        6        6           
Flag Coverage Δ
bridge 99.69% <ø> (ø)
explorer-frontend 95.00% <ø> (ø)
explorer-nodewatch 98.57% <ø> (ø)
explorer-rest 99.25% <ø> (ø)
faucet-authenticator 100.00% <ø> (ø)
faucet-backend 98.77% <ø> (ø)
faucet-frontend 100.00% <ø> (ø)
lightapi-python 98.67% <ø> (ø)
tools-shoestring 97.06% <100.00%> (+<0.01%) ⬆️
wallet-common-core 96.25% <ø> (ø)
wallet-common-ethereum 99.16% <ø> (ø)
wallet-common-symbol 95.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oestring/shoestring/commands/renew_certificates.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants