[tools/shoestring]: Fix ca.pubkey.pem not updated when renewing CA certificate#1590
Open
ccHarvestasya wants to merge 4 commits intosymbol:devfrom
Open
[tools/shoestring]: Fix ca.pubkey.pem not updated when renewing CA certificate#1590ccHarvestasya wants to merge 4 commits intosymbol:devfrom
ccHarvestasya wants to merge 4 commits intosymbol:devfrom
Conversation
* [explorer/nodewatch] Openapi - serve openapi using Flask
f18d312 to
3a736e0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1590 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 259 259
Lines 17821 17822 +1
Branches 215 215
=======================================
+ Hits 17236 17237 +1
Misses 579 579
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
ca.pubkey.pemwas not updated when runningrenew-certificates --renew-ca.Problem
--renew-careplaced the CA certificate, but the correspondingca.pubkey.pemfile remained outdated.Fix
ca.pubkey.pemis regenerated whenever the CA certificate is renewed with--renew-ca.Impact
ca.pubkey.pemis always regenerated alongside the renewed CA certificate.