Skip to content

[explorer/rest] feat: Added beneficiary properties in block query#1927

Open
AnthonyLaw wants to merge 4 commits intoexplorer/nem-backendfrom
explorer/rest-bug-fix-block-formatter
Open

[explorer/rest] feat: Added beneficiary properties in block query#1927
AnthonyLaw wants to merge 4 commits intoexplorer/nem-backendfrom
explorer/rest-bug-fix-block-formatter

Conversation

@AnthonyLaw
Copy link
Member

Problem: missing beneficiary field in query.
Solution: added beneficiary and renamed total_fee

@AnthonyLaw AnthonyLaw requested a review from Wayonb February 7, 2026 09:36
limit_condition=limit_condition
)

params.extend([min_height, limit, offset])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the param be initialized here instead of extend()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, extend is not needed.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.90%. Comparing base (c933172) to head (8698e29).

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           explorer/nem-backend    #1927   +/-   ##
=====================================================
  Coverage                 96.90%   96.90%           
=====================================================
  Files                       267      267           
  Lines                     19321    19331   +10     
  Branches                    215      215           
=====================================================
+ Hits                      18723    18733   +10     
  Misses                      592      592           
  Partials                      6        6           
Flag Coverage Δ
explorer-rest 99.53% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
explorer/rest/rest/db/NemDatabase.py 100.00% <100.00%> (ø)
explorer/rest/rest/model/Block.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants