Add mixed value like ConstraintValidatorInterface #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Member
|
can you please rebase on 3.x? i fixed the build in the 3.x branch. |
PHP Fatal error: Declaration of Symfony\Cmf\Bundle\RoutingBundle\Validator\Constraints\RouteDefaultsTwigValidator::validate($defaults, Symfony\Component\Validator\Constraint $constraint) must be compatible with Symfony\Component\Validator\ConstraintValidatorInterface::validate(mixed $value, Symfony\Component\Validator\Constraint $constraint): void in /home/erison/project s/SonataPageBundle/vendor/symfony-cmf/routing-bundle/src/Validator/Constraints/RouteDefaultsTwigValidator.php on line 34
eerison
force-pushed
the
validator-interface
branch
from
eb465e6 to
81f952e
Compare
Contributor
Author
|
I just run phpstan locally, and it looks fine now :) |
dbu
reviewed
Dec 3, 2025
Member
|
i tried to also provide symfony 8 support in #500, but that is more involved. afaik we also need to rewrite the service configuration from xml to php (there is a tool to at least automate it some). if you feel up to it, i am glad for contributions. meanwhile, i tagged https://github.com/symfony-cmf/routing-bundle/releases/tag/3.1.2 with symfony 7.4 no deprecations support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error message symfony 7.4/8.0 changed the Symfony\Component\Validator\ConstraintValidatorInterface:validate