[Platform] Simplify choice handling with multiple results #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
simplify-choice-handling
branch
from
6a3dc02 to
115bf8c
Compare
chr-hertel
commented
Jul 27, 2025
chr-hertel
force-pushed
the
simplify-choice-handling
branch
2 times, most recently
from
df60b01 to
3388480
Compare
chr-hertel
changed the title
chr-hertel
force-pushed
the
simplify-choice-handling
branch
9 times, most recently
from
61548ce to
5db093a
Compare
OskarStark
reviewed
Aug 1, 2025
OskarStark
reviewed
Aug 1, 2025
chr-hertel
force-pushed
the
simplify-choice-handling
branch
from
5db093a to
3affdb8
Compare
OskarStark
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of choices is that a completion result could have multiple results when option
nlarger than1. Until now theChoiceclass was rather simple and just assumed text or tool - and therefore in theory other choices where impossible. not sure anyone ever had an issue with this, but this now is more correct with encapsulating multiple results in theChoiceResult. Makes the code even easier and more correct.Pulled out of #136 to reduce the noise.
Examples:
