-
-
Notifications
You must be signed in to change notification settings - Fork 102
[AI Bundle][Platform] Add ModelCatalog
#640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModelCatalog
ModelCatalog
1106c17
to
65f3f3f
Compare
@chr-hertel do we need the |
cbfe1f1
to
663750f
Compare
OskarStark
commented
Sep 19, 2025
f982e57
to
f1fc8ba
Compare
0a32d4d
to
099f170
Compare
OskarStark
commented
Sep 23, 2025
OskarStark
commented
Sep 23, 2025
OskarStark
commented
Sep 23, 2025
OskarStark
commented
Sep 23, 2025
OskarStark
commented
Sep 23, 2025
OskarStark
commented
Sep 23, 2025
OskarStark
commented
Sep 23, 2025
OskarStark
commented
Sep 23, 2025
8fbb310
to
1440e16
Compare
a19e234
to
a3a1bf3
Compare
Will have a look at bedrock, but cannot test it on my own 👍🏻 |
just give me a ping and i'll rerun 👍 |
3c267aa
to
41d1ed5
Compare
chr-hertel
approved these changes
Sep 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's get it merged while it works :D
f39a859
to
4f06377
Compare
Thank you @OskarStark. |
Thanks for your help |
OskarStark
added a commit
that referenced
this pull request
Sep 28, 2025
This PR was squashed before being merged into the main branch. Discussion ---------- [AI Bundle] Fix service registration | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | Follows #640 | License | MIT Commits ------- 906041e [AI Bundle] Fix service registration
This was referenced Sep 29, 2025
OskarStark
added a commit
that referenced
this pull request
Oct 2, 2025
… syntax (OskarStark) This PR was merged into the main branch. Discussion ---------- [AI Bundle] Update documentation to use plain string model syntax | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | yes | Issues | Follows #640 | License | MIT Replace deprecated class and constant-based model configuration with plain string syntax across all examples in the AI Bundle documentation. Commits ------- 993490f [AI Bundle] Update documentation to use plain string model syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AI Bundle
Issues & PRs about the AI integration bundle
BC Break
Breaking the Backwards Compatibility Promise
Feature
New feature
Platform
Issues & PRs about the AI Platform component
Status: Reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recipe-PR:
ModelCatalog Architecture Refactoring
BC Breaks
$capabilities
parameterPlatformFactory
constructor changed for all bridges to be able to receive aModelCatalogInterface
PlatformInterface
now has an additionalgetModelCatalog
methodPlatformInterface::__invoke
no receives an model as string (beforeModel
)Vectorizer::__construct
no receives an model as string (beforeModel
)Agent::__construct
no receives an model as string (beforeModel
)Overview
This PR refactors how models are defined and managed in the Symfony AI Platform, moving from constants in Model classes to centralized ModelCatalogs.
Before (Old Configuration)
Defining Models
Models were defined as constants in Model classes:
Using Models
Adding Custom Models
There was no standardized way to add custom models. You had to:
After (New Configuration)
Defining Models
Models are now defined in centralized ModelCatalog classes:
Using Models
Adding Custom Models
Option 1: Via ModelCatalog Constructor
Option 2: Via Symfony Configuration (if using AI Bundle)
Benefits
Migration Guide
For Application Code
For Custom Platforms
Special Cases
HuggingFace
HuggingFace ModelCatalog accepts any model name since they support thousands of models:
Testing
All ModelCatalogs can now be tested using the base
ModelCatalogTestCase
: