Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP Parse errors in tests #1038

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Fix PHP Parse errors in tests #1038

merged 1 commit into from
Feb 9, 2025

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Feb 9, 2025 •
edited
Loading

PHP 7.1 and PHP 7.2 don't support a comma after a heredoc end (T_END_HEREDOC)

@rosier rosier marked this pull request as draft February 9, 2025 16:31
@rosier
Fix PHP Parse errors in tests.
7e76f08 
PHP 7.1 and PHP 7.2 don't support a comma after a heredoc end (T_END_HEREDOC)
@rosier rosier changed the title Run PHP lint first Fix PHP Parse errors in tests Feb 9, 2025
@rosier rosier marked this pull request as ready for review February 9, 2025 16:55
@fabpot
Copy link
Member

fabpot commented Feb 9, 2025

Thank you @rosier.

@fabpot fabpot merged commit 1aabc8e into symfony:1.x Feb 9, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosier @fabpot @stof