-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iepg #1460
Iepg #1460
Conversation
dsi-iepg
commented
Dec 13, 2022
Q | A |
---|---|
License | MIT |
Packagist |
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the PHP classes should be removed.
Entities won't work if the user is using PHP attributes instead of annotations for instance.
The bundle or the maker bundle should generate such classes. Probably a step to add in a post install text.
Head branch was pushed to by a user without write access
"src/": "%SRC_DIR%/" | ||
}, | ||
"env": { | ||
"#1": "#### Parameters for CAS connection ###", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not needed as Flex already adds some marker.
"#11": "#Where does the user go according to his role ", | ||
"#12": "#The default value is 'cas_dispatcher'", | ||
"CAS_DISPATCHER_NAME": "", | ||
"#13": "#### end of Cas-connection ####" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be removed as well
"#7": "#This value is optional", | ||
"#8": "#if it's 'false' you don't use ceretificat", | ||
"#9": "#THIS SETTING IS NOT RECOMMENDED FOR PRODUCTION!", | ||
"CAS_CA": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a string as env vars are always strings.
"env": { | ||
"#1": "#### Parameters for CAS connection ###", | ||
"CAS_HOST": "cas-adresse.com", | ||
"#2": "#This value is optional", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"#2": "#This value is optional", | |
"#2": "# This value is optional", |
Same for all commented lines.
access_control: | ||
- { path: ^/admin, roles: ROLE_ADMIN } | ||
- { path: ^/cas-connection/cas-admin, roles: ROLE_ADMIN } | ||
- { path: ^/cas-connection/cas-user, roles: ROLE_USER } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be removed as it will conflict with the one installed by the security component. Instead, you should add post install file to explain the next step about how to configure the bundle.
Head branch was pushed to by a user without write access
firewalls: | ||
main: | ||
provider: app_user_provider | ||
custom_authenticator: Iepg\Bundle\Cas\Controller\CasAuthenticator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole file must be removed :)
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Any progress here or can we close this PR @dsi-iepg |
Pull request was closed