Skip to content

Update security.yaml: Simplifying regex (#2) #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions symfony/security-bundle/7.3/config/packages/security.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
security:
# https://symfony.com/doc/current/security.html#registering-the-user-hashing-passwords
password_hashers:
Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface: 'auto'

# https://symfony.com/doc/current/security.html#loading-the-user-the-user-provider
providers:
users_in_memory: { memory: null }

firewalls:
# Disable security for dev tools and static assets (only needed if access_control is broad):
dev:
# 'assets/' is for AssetMapper, 'build/' for Webpack Encore.
# (Note: no regex delimiters needed; Symfony adds `{}` automatically.)
pattern: ^/(_profiler|_wdt|assets|build)/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem this addition solves ?

As neither webpack nor assetmapper have problems with the firewall today, as far as i know

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in dev, AssetMapper loads the file through the kernel, with a listener resolving them. You don't want the assets to be registered as the "last URL being accessed" under the firewall, saved in the session for the redirection after authentication.
Adding it for Webpack Encore is a safety measure avoiding the same kind of issue in case of a 404 on the built asset (for instance due to versioning), even though non-404 responses for Encore should be managed by the webserver directly (same applies for AssetMapper in production mode btw)

security: false
main:
lazy: true
provider: users_in_memory

# Activate different ways to authenticate:
# https://symfony.com/doc/current/security.html#the-firewall

# https://symfony.com/doc/current/security/impersonating_user.html
# switch_user: true

# Controls access to different sections of the application.
# Only the *first* matching rule is applied.
access_control:
# - { path: ^/admin, roles: ROLE_ADMIN }
# - { path: ^/profile, roles: ROLE_USER }

when@test:
security:
password_hashers:
# Password hashers are resource-intensive by design to ensure security.
# In tests, it's safe to reduce their cost to improve performance.
Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface:
algorithm: auto
cost: 4 # Lowest possible value for bcrypt
time_cost: 3 # Lowest possible value for argon
memory_cost: 10 # Lowest possible value for argon
3 changes: 3 additions & 0 deletions symfony/security-bundle/7.3/config/routes/security.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
_security_logout:
resource: security.route_loader.logout
type: service
12 changes: 12 additions & 0 deletions symfony/security-bundle/7.3/manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"bundles": {
"Symfony\\Bundle\\SecurityBundle\\SecurityBundle": ["all"]
},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
},
"aliases": ["security"],
"conflict": {
"symfony/framework-bundle": "<5.3"
}
}
Loading