[DependencyInjection] Add urlencode function to EnvVarProcessor
#19150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should target 7.1 🙂 |
OskarStark
changed the title
urlencode function to EnvVarProcessor
OskarStark
reviewed
Nov 20, 2023
alamirault
force-pushed
the
feature/19147-add-url-encode-processor
branch
from
9f19ddc to
4eb2f25
Compare
|
I read code target branch 🤦♂️ Rebased on 7.1 now |
|
Should we mention https://www.php.net/manual/en/function.urlencode.php somewhere? This may help people using it and bring additional doc to this feature 🙂 |
|
Thanks Antoine! Alex, I agree with you. We added the mention to PHP's |
|
Thank you both 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19147