Minor improvements #181
Open
Minor improvements #181
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jul 6, 2022
| return [ | ||
| 'webpack_encore.entrypoint_lookup_collection' => EntrypointLookupInterface::class, | ||
| 'webpack_encore.tag_renderer' => TagRenderer::class, | ||
| ]; |
There was a problem hiding this comment.
What's the point of adding this here and still having it defined in the service? https://github.com/symfony/webpack-encore-bundle/blob/main/src/Resources/config/services.xml#L29-L35
Can we have just this one (and remove the service config)? And if so, will it work even though there is no service with the id TagRenderer::class?
maxhelias
approved these changes
Apr 19, 2024
|
Status: Needs review (I'm testing CarsonBot integration) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.