Skip to content

Conversation

aruljenithberkmans
Copy link
Contributor

Bug Description

When the item source is changed dynamically for multiple area series, the Y-axis range does not update correctly. It continues to use the previous range instead of adjusting to the new minimum Y values.

Issue

Root Cause

In the SetData method, the series range is updated using the minimum and maximum values. If the new minimum value is zero, the code mistakenly uses the previous visible range's start value. This happens when the item source is changed dynamically and contains zero as the minimum value. This issue occurs specifically with multiple area series.ries.

Reason for the bug (maybe some wrong condition or wrong code)

The logic did not correctly handle the case when the minimum value is zero. It reused the previous axis range instead of recalculating it.

Why it fails because of the above reason?

  • The code assumes that a zero minimum value should use the previous visible range.
  • This leads to incorrect Y-axis scaling when the data source changes dynamically.

Reason for not identifying earlier

This test case was missed in previous testing.

Action taken:

  • Updated the logic to correctly handle zero minimum values.
  • Ensured the Y-axis range is recalculated when the item source changes.

Related areas:

  • Other Area types chart using dynamic data updates should be reviewed for similar issues.

Is Breaking issue?

No, this is not a breaking issue. The chart still renders, but the Y-axis range may be incorrect, affecting data visualization.

Solution description

  • Modified the SetData method to correctly calculate the Y-axis range even when the minimum value is zero.
  • Ensured the range updates properly when the item source changes.

Output Demo

Before changes

**After changes: **

Areas affected and ensured

  • AreaSegment

New Test cases

  • Tested Area series with change the itemsource dynamically.
  • Tested the Area series with double.NAN data points.
  • Tested the Area series with zero value in ypoint.
  • Tested the area series with zoom and panning.
  • Tested the area series with Auto scrolling.
  • Tested the Area series with Multiple area axis.

Is automated against existing test cases and ensured zero breaking

Add Centralized automation link

Does it have any known issues?

No known issues with this fix.

Does it have memory leak?

No memory leaks observed.

Does it affect the existing CPU usage for the live demo?

No significant impact on CPU usage.

Does it affect existing memory for the performance sample?

No significant impact on memory usage.

MR CheckList

  • Have you ensured in iOS, Android, WinUI, and macOS(if supported)?
  • If there is any API change, did you get approval from PLO through JIRA Tasks? NA
  • Is there any existing behavior change of other features due to this code change? NA
  • Did you perform the automation / manual testing against your fix?
  • Did you record this case in the unit test or UI test? NA
  • Have you suppressed any warning or binding errors? NA
  • Is there any existing behavior change of other features due to this code change? NA
  • Does it need localization? If so did you ensure the cases mentioned in this link? NA
  • Whether the new APIs and its comments are added as per standard? NA
  • Did you ensure the cases mentioned in this link? NA
  • Did you ensure the fix (if applicable) met accessibility requirements? NA
  • If you added any interaction related code, have you used touch and gesture APIs from core project? NA
  • Does it contain code that reflects any internal framework API? NA
  • Did you ensure the cases mentioned in this link? NA
  • Did you ensure RTL? NA
  • Did you test the memory leak with the fix? NA
  • Did you ensure the ? Check this link to know more about performance optimization and how to automate? NA
  • If you use a third-party package, did you get approval to use it? If not, please get approval before merging. NA

@PaulAndersonS
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants