Skip to content

fix: polish widget screens and previews#960

Merged
ovitrif merged 7 commits into
masterfrom
fix/widgets-small-fixes
May 22, 2026
Merged

fix: polish widget screens and previews#960
ovitrif merged 7 commits into
masterfrom
fix/widgets-small-fixes

Conversation

@jvsena42
Copy link
Copy Markdown
Member

@jvsena42 jvsena42 commented May 21, 2026

This PR:

  1. Renames the Bitcoin Price widget edit and preview screen titles for clarity
  2. Uppercases the weather label on the OS home-screen widget
  3. Darkens the in-app widget previews and OS widget background to gray6
  4. Removes the non-functional "Show Widget Titles" setting and its plumbing
  5. Removes the now-unused gray5 color

Description

A set of small follow-up fixes on top of the widgets foundation work.

The Bitcoin Price widget edit screen now titles itself "Bitcoin Price" instead of the generic "Widget Feed", and the Price preview screen header now reads "Widget Settings". The weather label on the OS home-screen widget is now uppercased to match the other widget labels.

The in-app widget previews and the OS app widget background now use gray6 (#1C1C1C) instead of gray5, and the now-unused gray5 color has been removed.

The "Show Widget Titles" setting has been removed end-to-end: the toggle in Widget Settings, its persisted value, the migration mapping, and the now-dead flows across the Home, Blocks, Suggestions, and Weather view models. The flag was never read by any renderer, so removing it has no visible effect beyond dropping the inert toggle. Existing persisted values are ignored safely on read.

Preview

home-widgets.webm
in-app-widgets.webm
removed-widget-title.webm

QA Notes

Manual Tests

  • 1. Home → add/edit Bitcoin Price widget → edit: AppBar title reads "Bitcoin Price" (not "Widget Feed").
  • 2. Bitcoin Price widget → preview: AppBar title reads "Widget Settings".
  • 3. Home screen (OS) → add Weather widget: the label is uppercased.
  • 4. in-app widget previews (Blocks, Facts, Headlines, Price, Weather) → background: darker gray6 tone.
  • 5. Home screen (OS) → any widget background: darker gray6 tone.
  • 6a. Settings → Widgets: no "Show Widget Titles" toggle is shown.
    • 6b. remaining Widgets toggles and reset actions still work.

Automated Checks

  • N/A — copy, color, and dead-code removal only; no automated coverage added or changed.
  • Local: compileDevDebugKotlin, testDevDebugUnitTest, and detekt all pass.

@jvsena42 jvsena42 self-assigned this May 21, 2026
@jvsena42 jvsena42 added this to the 2.3.0 milestone May 21, 2026
@jvsena42 jvsena42 requested a review from ovitrif May 21, 2026 17:33
@jvsena42 jvsena42 enabled auto-merge May 21, 2026 17:34
@ovitrif ovitrif requested a review from piotr-iohk May 22, 2026 01:26
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ovitrif ovitrif disabled auto-merge May 22, 2026 08:15
@ovitrif ovitrif merged commit a9aa230 into master May 22, 2026
36 of 45 checks passed
@ovitrif ovitrif deleted the fix/widgets-small-fixes branch May 22, 2026 08:15
@piotr-iohk
Copy link
Copy Markdown
Collaborator

@ovitrif please don't merge without CI being green. The failures need to be investigated.

@ovitrif
Copy link
Copy Markdown
Collaborator

ovitrif commented May 22, 2026

@ovitrif please don't merge without CI being green. The failures need to be investigated.

Sorry, too late this time 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants