feat: add onchain descriptor derivation#90
Merged
Conversation
ben-kaufman
force-pushed
the
feat/samrock-descriptor-api
branch
3 times, most recently
from
0469dd7 to
c839ec0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c839ec057f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ben-kaufman
force-pushed
the
feat/samrock-descriptor-api
branch
from
c839ec0 to
95278a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
derive_onchain_descriptorto the UniFFI API for deriving the receive/watch-only on-chain descriptor from a software wallet mnemonic.network,account_type, andaccount_index; the BIP39 passphrase is optional.xpubaccount keys while preserving the selected network coin type in the origin path.0.1.60, with regenerated iOS, Android, and Python bindings plus an updated SwiftPM checksum.Testing
cargo fmt --checkcargo test derive_onchain_descriptor./build.sh -r --patch all