refactor(ui): InsetHeaderScrollView, shared tab swipes#535
refactor(ui): InsetHeaderScrollView, shared tab swipes#535
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8e3162b57
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "lightbulb.pdf", |
There was a problem hiding this comment.
Point lightbulb image set to the actual asset file
This image set declares "filename": "lightbulb.pdf", but the commit only adds lightbulb.png in that folder, so the catalog entry points to a non-existent file. As a result, Image("lightbulb") (for example in profile hint UIs) can render as missing at runtime or fail asset validation in build tooling. Update the filename to lightbulb.png (or add the referenced PDF) so the asset resolves correctly.
Useful? React with 👍 / 👎.
Description
InsetHeaderScrollViewwith measured topsafeAreaInsetheader + scroll contentminHeightto fill the viewport below. To be used on scrollable screens with headers likeAllActivity,MainSettings,ShopDiscover.swipeSegmentedTabsforAllActivity,MainSettings, andShopDiscoversegmented controls (horizontal swipe to change tabs).CardviewsScreenshot / Video
Simulator.Screen.Recording.-.iPhone.17.-.2026-05-04.at.23.44.27.mov
QA Notes
Make sure changed screens look polished and suggestion/shop cards still work as expected.