Skip to content

refactor(ui): InsetHeaderScrollView, shared tab swipes#535

Open
pwltr wants to merge 2 commits intomasterfrom
fix/sticky-nav
Open

refactor(ui): InsetHeaderScrollView, shared tab swipes#535
pwltr wants to merge 2 commits intomasterfrom
fix/sticky-nav

Conversation

@pwltr
Copy link
Copy Markdown
Contributor

@pwltr pwltr commented May 4, 2026

Description

  • add a reusable InsetHeaderScrollView with measured top safeAreaInset header + scroll content minHeight to fill the viewport below. To be used on scrollable screens with headers like AllActivity, MainSettings, ShopDiscover.
  • add swipeSegmentedTabs for AllActivity, MainSettings, and ShopDiscover segmented controls (horizontal swipe to change tabs).
  • refactor Card views
  • fix "lightbulb" figure image

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.17.-.2026-05-04.at.23.44.27.mov

QA Notes

Make sure changed screens look polished and suggestion/shop cards still work as expected.

@pwltr pwltr self-assigned this May 4, 2026
@pwltr pwltr added this to the 2.3.0 milestone May 4, 2026
@pwltr pwltr marked this pull request as ready for review May 4, 2026 21:46
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a8e3162b57

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

{
"images" : [
{
"filename" : "lightbulb.pdf",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Point lightbulb image set to the actual asset file

This image set declares "filename": "lightbulb.pdf", but the commit only adds lightbulb.png in that folder, so the catalog entry points to a non-existent file. As a result, Image("lightbulb") (for example in profile hint UIs) can render as missing at runtime or fail asset validation in build tooling. Update the filename to lightbulb.png (or add the referenced PDF) so the asset resolves correctly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant