feat: add contact payment UI#553
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c15ee26c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
42aba93 to
c55532d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
About 2, I guess this is mostly a design / UI choice. |
Added comment in figma. |
This comment was marked as resolved.
This comment was marked as resolved.
2544b1c to
302687b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
piotr-iohk
left a comment
There was a problem hiding this comment.
LGTM. Re-tested failed scenarios - now pass.
Also no issue observed in e2e tests after paykit update.
Description
Adds the contact-payment UI that was intentionally left out of the private Paykit PR:
This targets
codex/paykit-private-paymentsso it can be reviewed separately from the private Paykit core work.Linked Issues/Tasks
Refs #539
Screenshot / Video
Not attached in this PR body. The UI was validated locally against the simulator flow, and this branch is intentionally scoped to UI/wiring on top of the private payments branch.
Verification
swiftformat --lint Bitkit/Services/PrivatePaykitService+Endpoints.swift Bitkit/ViewModels/SettingsViewModel.swift Bitkit/Views/Settings/General/PaymentPreferenceView.swift Bitkit/Views/Wallets/Activity/ActivityRow.swift Bitkit/Views/Wallets/Activity/ActivityItemView.swift Bitkit/Views/Wallets/Send/SendContactSelectView.swift Bitkit/Views/Wallets/Send/SendOptionsView.swift Bitkit/Views/Wallets/Send/SendSheet.swift Bitkit/Views/Wallets/Activity/AssignActivityContactView.swift Bitkit/Components/PubkyContactAvatar.swift Bitkit/Components/PubkyContactRow.swiftgit diff --checkgit diff --cached --checknode scripts/validate-translations.jsenv DEVELOPER_DIR=/Users/benk10/Downloads/Old\ Mac\ Backup/Xcode.app/Contents/Developer xcodebuild -quiet -project Bitkit.xcodeproj -scheme Bitkit -configuration Debug -destination id=15FE6795-02FB-4073-A427-63F0B39A3A17 -derivedDataPath /private/tmp/bitkit-contact-ui-build build