fix: gate paykit ui#560
Merged
Merged
Conversation
piotr-iohk
previously approved these changes
May 21, 2026
Collaborator
piotr-iohk
left a comment
There was a problem hiding this comment.
LGTM functionally. Paykit UI is off by default; the Dev Settings toggle works.
When disabled:
- Drawer Profile/Contacts → Coming Soon
- Send → Contacts → Coming Soon
- Tx details — no assign-to-contact button
- Send → enter/paste/scan pubky → unable to read
pushed test ids to handle feature flag on e2e side.
ovitrif
reviewed
May 21, 2026
ovitrif
previously approved these changes
May 21, 2026
c3b4ede to
7a2025d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #556
Description
This PR:
Linked Issues/Tasks
Closes #556
Screenshot / Video
N/A
QA Notes
Manual Tests
regression:Paykit previously enabled -> update with Paykit UI disabled -> app startup/foreground: published endpoints are cleaned up or left pending for retry.Automated Checks
git diff --checkswiftformat --linton touched Swift filesnode scripts/validate-translations.jsE2E_BUILDE2E_BUILD PAYKIT_UI_DISABLEDBitkitTests/ContactsManagerTests.swift; targeted test execution is currently blocked by existing unrelatedStateLockerTestscompile errors in the test target.