Add basic retry mechanism to sig-repo jar download #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to override/disable retry behavior easily via environment variable, and add default backoff and maximum time values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a recent attempt to plan maintenance for the binary repository backing sig-repo, it was determined that retry-less client behavior is complicating the ability to patch and maintain the system.
This pull request proposes the addition of basic retry logic - there are many options which can alter the behavior of the default retry. Note that
--failmust be added if retry on 404 is desired (which will depend on sig-repo's behavior when down).It might also be appropriate to setup the ability to disable or override the retry behavior via environment variable, similar to the base
DETECT_CURL_OPTSsetup.Aside from determinations on what the default behavior should be, another addition that would be appropriate would be similar support in the powershell script (which based on surface research seems slightly more involved, and being unfamiliar with PS I decided would be better to exclude and allow someone better-versed to provide)