Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional config to require a login to access the terminal. #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optional config to require a login to access the terminal. #9

wants to merge 2 commits into from

Conversation

oskar-kupski-elpassion
Copy link

#4

@syntaxseed
Copy link
Owner

Is this still a work in progress?

  • The username and password should be configurable and password should be hashed.

Looks great though. I will try it out soon.

@oskar-kupski-elpassion
Copy link
Author

oskar-kupski-elpassion commented Oct 3, 2019 via email

@oskar-kupski-elpassion
Copy link
Author

Hi, I moved, the configuration of username and password to index.html file. If they are not defined and login is required an error is thrown. Please let me know if it meets your expectations now :)

@syntaxseed
Copy link
Owner

Note that PR #13 will be merged before the others once it is fully reviewed. This one may need a rebase at that time.

Thanks!

@syntaxseed
Copy link
Owner

Please rebase & test now that a major refactor has been merged. Thanks!

@syntaxseed syntaxseed added the needs rebase This PR needs a rebase and review, re-test due to divergence from master. label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs rebase This PR needs a rebase and review, re-test due to divergence from master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oskar-kupski-elpassion @syntaxseed