Skip to content

🌱 fixing hanging deprovisioning #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

🌱 fixing hanging deprovisioning #1585

wants to merge 6 commits into from

Conversation

guettli
Copy link
Collaborator

@guettli guettli commented Apr 17, 2025

fixing hanging deprovisioning

Additionally:

Avoid

Warning: Reconciler returned both a non-zero result and a non-nil error.
The result will always be ignored if the error is non-nil and the non-nil error
causes reqeueuing with exponential backoff. For more details,
see: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/reconcile#Reconciler

@guettli
🌱 fixing hanging deprovisioning
e50564a 
fixing hanging deprovisioning

Additionally:

Avoid

> Warning: Reconciler returned both a non-zero result and a non-nil error.
> The result will always be ignored if the error is non-nil and the non-nil error
> causes reqeueuing with exponential backoff. For more details,
> see: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/reconcile#Reconciler
@guettli guettli marked this pull request as draft April 17, 2025 07:54
@github-actions github-actions bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. area/github Changes made in the github directory area/code Changes made in the code directory labels Apr 17, 2025
@github-actions github-actions bot added size/L Denotes a PR that changes 200-800 lines, ignoring generated files. and removed size/M Denotes a PR that changes 50-200 lines, ignoring generated files. labels Apr 23, 2025
@guettli
Copy link
Collaborator Author

guettli commented May 9, 2025

already merged in other PR.

@guettli guettli closed this May 9, 2025
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. and removed size/L Denotes a PR that changes 200-800 lines, ignoring generated files. labels May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/code Changes made in the code directory area/github Changes made in the github directory size/XS Denotes a PR that changes 0-20 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@guettli