Skip to content

fix build on non-glibc Linux #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix build on non-glibc Linux #808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/helpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#define stat64 __stat64
#endif

#if defined(__APPLE__)
#if defined(__APPLE__) || !defined (__GLIBC__)
Copy link

@cmeerw cmeerw May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that change is correct - it would conflict with the define for stat64 when _MSC_VER is defined (above)

Maybe (assuming that __GLIBC__ isn't defined for __APPLE__ anyway):

#ifdef _MSC_VER
#define stat64 __stat64
#elif !defined(__GLIBC__)
#define stat64 stat
#endif

#define stat64 stat
#endif

Expand Down