feat: TEP89Proxy standard proof added #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruitful1l
changed the title
Kaladin13
requested changes
Dec 9, 2025
Collaborator
Kaladin13
left a comment
Kaladin13
left a comment
There was a problem hiding this comment.
Great pr overall: let's add tests (perfectly just make existing one work) and fix a few comments
| action: Cell<JettonTransferNotificationWithVaultAction> | ||
| } | ||
|
|
||
| struct (0xd1735400) TakeWalletAddress { |
Collaborator
There was a problem hiding this comment.
Maybe let's reuse existing message type? I think it already exist
Author
There was a problem hiding this comment.
Doesn't exist in messages.tolk, couldn't find it in other files as well, not sure if it's somewhere there
| includeAddress: bool | ||
| } | ||
|
|
||
| type AllowedMessagesForProxy = TakeWalletAddress |
Collaborator
There was a problem hiding this comment.
let's move this to the place where it is used, e.g. proxy.tolk on top
| } | ||
|
|
||
| fun checkProof(proof: JettonVaultProof, minter: address, msgSender: address) { | ||
| fun exit(): void |
Collaborator
There was a problem hiding this comment.
lets add comment why we need this (also cant we do this with raw return since this is Tolk?)
| discoveryId: uint64 // Unique discovery ID (salt) | ||
| } | ||
|
|
||
| fun ProxyStorage.load() { |
Collaborator
There was a problem hiding this comment.
Move to the proxy file on top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TEP89 Proof alongside minor change in the JettonVault storage, now containing the ref to Proxy contract code. Made temporary wrapper for it, requires tests adaptation from tact dex repo.