Skip to content

Conversation

aigerimu
Copy link
Contributor

@aigerimu aigerimu commented Oct 4, 2025

closes #554

@aigerimu aigerimu requested review from a team and verytactical as code owners October 4, 2025 14:06
Copy link

github-actions bot commented Oct 4, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --quiet --silently-ignore ecosystem/explorers/tonviewer.mdx ecosystem/wallet-apps/web.mdx 

Copy link

github-actions bot commented Oct 5, 2025

Thanks for the focused updates to the TON explorer docs. A few high‑priority fixes are needed before merge.

Findings (3)

High (3)

[HIGH] Incorrect TON unit conversion from nanotons (ng)

Location:

- However, when attempting to forward the transfer, the wallet's **remaining balance (194.519994 TON)** was **less than the required total (200.4 TON)**, including forwarding fees:

Description:
The bullet states TON amounts that actually correspond to nanotons (ng) shown in the adjacent log. The values 194519994ng and 200400000ng equal 0.194519994 TON and 0.2004 TON, respectively, so the text overstates by three orders of magnitude.

Suggestion:

- - However, when attempting to forward the transfer, the wallet's **remaining balance (194.519994 TON)** was **less than the required total (200.4 TON)**, including forwarding fees:
+ - However, when attempting to forward the transfer, the wallet's **remaining balance (0.194519994 TON)** was **less than the required total (0.2004 TON)**, including forwarding fees:

[HIGH] UI label not quoted: “Actions cell (C5)”

Location:

2. **Check the Actions cell (C5)**

Description:
In the “Steps to debug” section, the UI label Actions cell (C5) appears without quotation marks, which violates the style guide for UI/log strings. The same issue occurs later at ecosystem/explorers/tonviewer.mdx?plain=1#L252-L252. UI strings must be wrapped in quotation marks using the international style.

Suggestion:

--- a/ecosystem/explorers/tonviewer.mdx
+++ b/ecosystem/explorers/tonviewer.mdx
@@
-2. **Check the Actions cell (C5)**
+2. **Check “Actions cell (C5)”**
@@
-ii. **Check the Actions cell (C5)**
+ii. **Check “Actions cell (C5)”**

[HIGH] UI string formatted as code instead of quotes: “message mode = 3”

Location:

In [Actions cell (C5)](https://retracer.ton.org/?tx=d149392f77214e2f4af7c516777d168e6c3e71f8666f76fb743eb85d57922d0d&testnet=true), we see `message mode = 3`, where mode `3` combines two flags:

Description:
The literal UI/log string message mode = 3 is rendered as inline code rather than quoted text, contrary to the style guide. Exact UI/log messages should use quotation marks (international style) for clarity and copy/grep fidelity.

Suggestion:

--- a/ecosystem/explorers/tonviewer.mdx
+++ b/ecosystem/explorers/tonviewer.mdx
@@
-In [Actions cell (C5)](https://retracer.ton.org/?tx=d149392f77214e2f4af7c516777d168e6c3e71f8666f76fb743eb85d57922d0d&testnet=true), we see `message mode = 3`, where mode `3` combines two flags:
+In “[Actions cell (C5)](https://retracer.ton.org/?tx=d149392f77214e2f4af7c516777d168e6c3e71f8666f76fb743eb85d57922d0d&testnet=true)”, we see “message mode = 3”, where mode “3” combines two flags:

@hacker-volodya hacker-volodya removed the request for review from a team October 7, 2025 18:59
Copy link

github-actions bot commented Oct 8, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore ecosystem/explorers/tonviewer.mdx ecosystem/wallet-apps/web.mdx 

Copy link

github-actions bot commented Oct 8, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore ecosystem/explorers/tonviewer.mdx ecosystem/wallet-apps/web.mdx guidebook/debug.mdx 

Copy link

github-actions bot commented Oct 8, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore ecosystem/explorers/tonviewer.mdx guidebook/debug.mdx 

Copy link

github-actions bot commented Oct 8, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore ecosystem/explorers/tonviewer.mdx guidebook/debug.mdx 

Copy link

github-actions bot commented Oct 8, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore ecosystem/explorers/tonviewer.mdx guidebook/debug.mdx 

@aigerimu aigerimu requested a review from Shvandre October 9, 2025 14:45
@verytactical verytactical marked this pull request as draft October 10, 2025 15:38
@aigerimu aigerimu marked this pull request as ready for review October 13, 2025 05:49
Copy link

Thanks for the updates. I reviewed the changes between main and pr_head across the touched files and found no issues; no fixes are needed at this time.

Copy link
Collaborator

@verytactical verytactical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure

image

@verytactical verytactical marked this pull request as draft October 13, 2025 23:06
@aigerimu aigerimu marked this pull request as ready for review October 14, 2025 08:46
Copy link

Thanks for the updates across tonviewer.mdx, debug guide, and the dictionary. One small style fix is needed in tonviewer.mdx.

Findings (1)

High (1)

[HIGH] Removed code formatting for literal identifier

Location:

- A — sender's wallet contract (mintmachine.ton).

Description:
Backticks were removed around the literal identifier mintmachine.ton in list items, reducing scannability and violating the style rule requiring code font for literals. The primary instance is at L72; the same issue also occurs at ecosystem/explorers/tonviewer.mdx:129. Style rule reference: https://github.com/tact-lang/mintlify-ton-docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L284-L287.

Suggestion:
Restore backticks around the literal in both occurrences.

--- a/ecosystem/explorers/tonviewer.mdx
+++ b/ecosystem/explorers/tonviewer.mdx
@@
- - A — sender's wallet contract (mintmachine.ton).
+ - A — sender's wallet contract (`mintmachine.ton`).
@@
- - A — user's mintmachine.ton account, sending the initial funds.
+ - A — user's `mintmachine.ton` account, sending the initial funds.

Shvandre
Shvandre previously approved these changes Oct 14, 2025
Copy link
Collaborator

@Shvandre Shvandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix merge conflict and let's gooooo

Copy link

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore ecosystem/explorers/tonviewer.mdx guidebook/debug.mdx 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ecosystem > Explorers > Tonviewer] Add cases with retracer

3 participants