-
Notifications
You must be signed in to change notification settings - Fork 0
wallet.ton.org #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
wallet.ton.org #583
Conversation
To fix the formatting issues:
npx remark -o --quiet --silently-ignore ecosystem/wallet-apps/web.mdx |
Thanks for the updates to the wallet docs. A few blocking issues remain in the web wallet page that need fixes before we can merge. Findings (3)High (3)[HIGH] Misleading link target for “wallet.ton.org”Location:
Description: Suggestion: - [wallet.ton.org](https://github.com/ton-blockchain/ton-wallet) is the self-custodial wallet developed by TON Core.
+ [wallet.ton.org](https://wallet.ton.org/) is the self-custodial wallet developed by TON Core. [HIGH] Incomplete sections and placeholder steps block useLocation: mintlify-ton-docs/ecosystem/wallet-apps/web.mdx Lines 23 to 37 in 92ebdfa
Description: Suggestion: -## Wallet setup
-
-We demonstrate wallet setup using the **web version** of [wallet.ton.org](https://wallet.ton.org/).
-This allows developers to complete all steps on a single device without switching platforms.
-
-1. Open
-
-
-### Testnet
-
-
-## First transactions
-
-
-## See also [HIGH] Incomplete procedure step blocks task executionLocation:
Description: Suggestion: -1. Open
+1. Open https://wallet.ton.org/. |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
Thanks for the update to the wallet docs. I found a few blocking issues in ecosystem/wallet-apps/web.mdx that need fixes before merge. Findings (4)High (4)[HIGH] Missing security warning for recovery wordsLocation: mintlify-ton-docs/ecosystem/wallet-apps/web.mdx Lines 104 to 106 in c3416af
Description: Suggestion: -<Aside type="caution">
- The following recovery words are shown only for demonstration purposes.
-</Aside>
+<Aside type="warning">
+ Warning — funds and keys at risk
+ Exposing or storing recovery words can compromise your wallet.
+ Scope: anyone with these words can take your funds.
+ Rollback: none. If leaked, move funds to a new wallet.
+ Environment: applies to TON Mainnet and TON Testnet.
+ The words below are for demonstration only.
+</Aside> [HIGH] Step numbering skips 4–5 and continues at 6–10Location: mintlify-ton-docs/ecosystem/wallet-apps/web.mdx Lines 75 to 116 in c3416af
Description: Suggestion: -6. Read the **Use Responsibly** notice and check the box to _confirm that you have read and accepted this information_.
+4. Read the **Use Responsibly** notice and check the box to _confirm that you have read and accepted this information_.
-7. After confirming, you’ll be prompted to manually back up your secret key.
+5. After confirming, you’ll be prompted to manually back up your secret key.
-8. Read the **Safety Rules** carefully, check all the boxes to confirm that you understand them. Then click **Understood** to continue.
+6. Read the **Safety Rules** carefully, check all the boxes to confirm that you understand them. Then click **Understood** to continue.
-9. Write down your 24 recovery words and store them in **a safe place**.
+7. Write down your 24 recovery words and store them in **a safe place**.
-10. In the **Let’s Check** step, enter the requested words to make sure your recovery phrase was saved correctly.
+8. In the **Let’s Check** step, enter the requested words to make sure your recovery phrase was saved correctly. [HIGH] Placeholder faucet link is brokenLocation: mintlify-ton-docs/ecosystem/wallet-apps/web.mdx Lines 217 to 219 in c3416af
Description: Suggestion: -- On Testnet, request free Testnet Toncoins from the [TON Testnet Faucet](link).
+- On Testnet, request free Testnet Toncoins from the [TON Testnet Faucet](https://t.me/testgiver_ton_bot). [HIGH] Incorrect account status term (“nonexistent” vs canonical “nonexist”)Location:
Description: Suggestion: -Newly created wallets have the default state **nonexistent**, meaning the account has _no code, data, or balance_.
+Newly created wallets have the default state **nonexist**, meaning the account has _no code, data, or balance_. |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
![]() it suggests:
So, could we ignore it? |
Thanks for the focused docs update in the ecosystem wallet guide. I found several style‑guide blockers that need fixes before merge. Findings (3)High (3)[HIGH] UI/log messages are styled in bold instead of quotedLocation:
Description: Suggestion: --- a/ecosystem/wallet-apps/web.mdx
+++ b/ecosystem/wallet-apps/web.mdx
@@ -31 +31 @@
-2. Click **Create Wallet** to create a new wallet.
+2. Click "Create Wallet" to create a new wallet.
@@ -39 +39 @@
-3. Next, choose **Use Password** to protect your wallet:
+3. Next, choose "Use Password" to protect your wallet:
@@ -259 +259 @@
-1. Click **Send**, enter your wallet address in **Recipient Address**, and the **Amount** of TON. Optionally, add a comment. Click **Send TON**.
+1. Click "Send", enter your wallet address in "Recipient Address", and the "Amount" of TON. Optionally, add a comment. Click "Send TON".
@@ -267 +267 @@
-2. In the confirmation popup, verify the transaction details and click **Confirm** if correct; otherwise, **Edit**.
+2. In the confirmation popup, verify the transaction details and click "Confirm" if correct; otherwise, "Edit".
@@ -275 +275 @@
-3. After confirmation, the wallet will display a notification: **Coins have been sent!**
+3. After confirmation, the wallet displays the notification "Coins have been sent!" [HIGH] Safety callout for mnemonic handling is incomplete (missing risk, scope, rollback, environment)Location: mintlify-ton-docs/ecosystem/wallet-apps/web.mdx Lines 85 to 89 in 845ae55
Description: Suggestion: -<Aside
- type="caution"
->
- The following recovery words are shown only for demonstration purposes.
-</Aside>
+<Aside type="danger" title="Secrets at risk">
+ Risk: Exposing recovery words lets others take your wallet and funds.
+ Scope: Affects this wallet and any accounts derived from its mnemonic.
+ Rollback: If exposure is suspected, move funds to a new wallet and stop using the old mnemonic.
+ Environment: Handle mnemonics offline and in private; do not enter them on untrusted sites. Prefer Testnet for demos.
+</Aside> [HIGH] Missing required safety callout before moving fundsLocation: mintlify-ton-docs/ecosystem/wallet-apps/web.mdx Lines 251 to 260 in 845ae55
Description: Suggestion: ### Send the first transaction
With TON in the account, the wallet can be deployed. Deployment occurs when _the wallet processes its first transaction_.
In this example, we send TON to the account itself on Testnet to observe the transaction and wallet deployment on-chain.
+<Aside type="danger" title="Funds at risk">
+ Risk: The next steps transfer funds. Mainnet transfers are irreversible.
+ Scope: Your wallet balance and the specified recipient address.
+ Mitigation/Rollback: Use TON Testnet for this example. On mainnet, double‑check the recipient and amount before confirming; there is no rollback after submission.
+ Environment: Prefer TON Testnet for testing; switch to mainnet only when ready.
+</Aside>
To send TON to your own account: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aigerimu merge conflicts + failing CI
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
done |
closes #138