-
Notifications
You must be signed in to change notification settings - Fork 0
fill how to find jetton wallet page #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To fix the formatting issues:
npx remark -o --quiet --silently-ignore standard/tokens/jettons/how-to-find-Jetton-wallet.mdx |
To fix the formatting issues:
npx remark -o --quiet --silently-ignore standard/tokens/jettons/how-to-find-Jetton-wallet.mdx |
Thanks for the Jettons wallet doc update. A few high‑severity style‑guide issues need fixes before this can merge, all within Findings (3)High (3)[HIGH] Placeholders not defined on first useLocation:
Description: Suggestion: --- a/standard/tokens/jettons/how-to-find-Jetton-wallet.mdx
+++ b/standard/tokens/jettons/how-to-find-Jetton-wallet.mdx
@@
import TonWeb from 'tonweb';
const tonweb = new TonWeb();
-const JettonMinter = new TonWeb.token.jetton.JettonMinter(tonweb.provider, { address: '<jetton_MASTER_ADDRESS>' });
+const JettonMinter = new TonWeb.token.jetton.JettonMinter(tonweb.provider, { address: '<JETTON_MASTER_ADDRESS>' });
const jettonWalletAddress = await JettonMinter.getJettonWalletAddress(new TonWeb.utils.Address('<OWNER_WALLET_ADDRESS>'));
@@
console.log('jetton wallet address:', jettonWalletAddress.toString(true, true, true)); +Define placeholders (first use):
[HIGH] Unlabeled partial code snippetsLocation:
Description: Suggestion: --- a/standard/tokens/jettons/how-to-find-Jetton-wallet.mdx
+++ b/standard/tokens/jettons/how-to-find-Jetton-wallet.mdx
@@
the Jetton master contract provides the `get_wallet_address (slice owner_address)` method.
+Not runnable
```typescript
@@
-However, if you know the jetton wallet code and storage structure, you can calculate the wallet address without making network requests.
+However, if you know the jetton wallet code and storage structure, you can calculate the wallet address without making network requests.
+Not runnable
```typescript
@@
-of the Jetton wallet and thus calculate its address.
+of the Jetton wallet and thus calculate its address.
+Not runnable
```typescript |
…lify-ton-docs into how-to-find-jetton-wallet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few more comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about getting it onchain? or do we have that covered in some other page?
…lify-ton-docs into how-to-find-jetton-wallet
To fix the formatting issues:
npx remark -o --silent --silently-ignore standard/tokens/jettons/how-to-find.mdx |
Thanks for the update to the Jetton docs. One blocking fix is needed before merge to keep examples copy/paste‑safe. Findings (1)High (1)[HIGH] Code examples not copy‑pasteable; placeholders missing/undefinedLocation:
Description: Suggestion: Suggested change (Reviewer #2): --- a/standard/tokens/jettons/how-to-find.mdx
+++ b/standard/tokens/jettons/how-to-find.mdx
@@
- const jettonMasterAddress = Address.parse(
- "put the Jetton master address in any format",
- );
- const walletAddress = Address.parse("put owner's address in any format");
+ const jettonMasterAddress = Address.parse("EQC_REPLACE_WITH_MASTER_ADDRESS");
+ const walletAddress = Address.parse("EQC_REPLACE_WITH_OWNER_ADDRESS");
@@
-const ownerAddress = Address.parse("an address in any format");
+const ownerAddress = Address.parse("EQC_REPLACE_WITH_OWNER_ADDRESS");
@@
-void main();
+void main();
+
+Placeholders:
+- EQC_REPLACE_WITH_MASTER_ADDRESS — Jetton master address (any supported string form).
+- EQC_REPLACE_WITH_OWNER_ADDRESS — owner wallet address (any supported string form). Suggested change (Reviewer #4): --- a/standard/tokens/jettons/how-to-find.mdx
+++ b/standard/tokens/jettons/how-to-find.mdx
@@
- const jettonMasterAddress = Address.parse(
- "put the Jetton master address in any format",
- );
- const walletAddress = Address.parse("put owner's address in any format");
+ const jettonMasterAddress = Address.parse("<JETTON_MASTER_ADDR>");
+ const walletAddress = Address.parse("<OWNER_ADDR>");
@@
void main(); +Define placeholders (first use):
|
Closes #217