-
Notifications
You must be signed in to change notification settings - Fork 0
fix: warning case #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: warning case #654
Conversation
Thanks for the updates. I reviewed the changes between |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/node/mytonctrl/backups.mdx ecosystem/node/setup-mytonctrl.mdx ecosystem/tma/mate/hosting.mdx guidebook/debug.mdx guidebook/first-smart-contract.mdx pending/reference/new-smart-contracts/interactions/extra.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/node/mytonctrl/backups.mdx ecosystem/node/setup-mytonctrl.mdx ecosystem/tma/mate/hosting.mdx guidebook/debug.mdx guidebook/first-smart-contract.mdx pending/reference/new-smart-contracts/interactions/extra.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/node/mytonctrl/backups.mdx ecosystem/node/setup-mytonctrl.mdx ecosystem/tma/mate/hosting.mdx guidebook/debug.mdx guidebook/first-smart-contract.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/node/mytonctrl/backups.mdx ecosystem/node/setup-mytonctrl.mdx ecosystem/tma/mate/hosting.mdx guidebook/debug.mdx guidebook/first-smart-contract.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/node/mytonctrl/backups.mdx ecosystem/node/setup-mytonctrl.mdx ecosystem/tma/mate/hosting.mdx guidebook/debug.mdx guidebook/first-smart-contract.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/node/mytonctrl/backups.mdx ecosystem/node/setup-mytonctrl.mdx ecosystem/tma/mate/hosting.mdx guidebook/debug.mdx guidebook/first-smart-contract.mdx |
@anton-trunov review again pls, problem was with imports |
Thanks for the updates across the node setup and backups docs. A few safety callouts need adjustments before this can merge. Findings (3)High (3)[HIGH] Safety callout downgraded to caution for key exposureLocation:
Description: Suggestion: - type="caution"
+ type="warning" [HIGH] Safety callout downgraded to caution on key handlingLocation:
Description: Suggestion: -<Aside type="caution">
+<Aside type="warning"> [HIGH] Safety callout missing required elements (risk, scope, rollback, environment)Location:
Description: Suggestion: -<Aside type="caution">**Handle validator keys like production secrets.** Keep recovery phrases offline, restrict shell access, and rehearse new procedures on testnet before touching wallets that hold real stake.</Aside>
+<Aside type="caution">
+**Handle validator keys like production secrets.** Keep recovery phrases offline, restrict shell access, and rehearse new procedures on testnet before touching wallets that hold real stake.
+Risk: key exposure enables account takeover; shell access escalation.
+Scope: validator keys and this node’s configuration.
+Rollback: rotate keys and restore from a known‑good backup.
+Environment: practice on TON Testnet before using TON Mainnet.
+</Aside> |
Out of scope in this PR |
Closes #653
Closes #657