-
Notifications
You must be signed in to change notification settings - Fork 6
Use pip3, pre-commit v2.13.0 and split RUN #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexs77
wants to merge
15
commits into
taghash:master
Choose a base branch
from
alexs77:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit is now at v2.13.0 and requires Python 3. Install the `python3-pip` package for that and use `pip3`. Also split the one `RUN` command into separate ones, so that an update of pre-commit doesn't require a rebuild of everything.
Use pip3, pre-commit v2.13.0 and split RUN
Look for podman as an exeuctable for running the container. If not found, look for docker as well.
Look for podman as an exeuctable for running the container. If not found, look for docker as well.
Use podman instead of docker executable
Look for podman and docker, in this order.
At least podman prints the ID of the restarted container on stdtout. We don't need that.
Use podman
Cleanup README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit is now at v2.13.0 and requires Python 3. Install the
python3-pip
package for that and usepip3
.Also split the one
RUN
command into separate ones, so that an update of pre-commit doesn't require a rebuild of everything.