Updating to use tokens to replace cookies in bugzilla >= 4.4.3 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. I was about to work on that. as the token is required since 4.4.3, that would be better checking bugzilla API version before doing and shouldn't remove the code for cookie. |
|
This patch supports both cookies and tokens depending on the version. I've been testing it moving between both and it seems to work fine. |
|
Just wanted to follow up and see if there was anything you needed me to do to get this merged. |
csabahenk
pushed a commit
to csabahenk/ruby-bugzilla-nomagick
that referenced
this pull request
Jul 14, 2017
refactored some repeated code into own function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.