Skip to content

feat(addon-table): added expandable table behaviour #10694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 24, 2025

Conversation

aasereb7
Copy link
Contributor

Fixes UIKIT-7766

@aasereb7 aasereb7 requested a review from a team as a code owner March 30, 2025 08:05
@aasereb7 aasereb7 requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team March 30, 2025 08:05
Copy link

nx-cloud bot commented Mar 30, 2025

View your CI Pipeline Execution ↗ for commit 1a9f46b.

Command Status Duration Result
nx run-many --target test --all --output-style=... ✅ Succeeded 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-24 10:01:03 UTC

Copy link

screenshot-report-bot bot commented Mar 30, 2025

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 32.35294% with 23 lines in your changes missing coverage. Please review.

Project coverage is 64.98%. Comparing base (52abe54) to head (1a9f46b).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...nents/table/table-expand/table-expand.component.ts 26.66% 21 Missing and 1 partial ⚠️
...on-table/components/table/tbody/tbody.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10694      +/-   ##
==========================================
- Coverage   65.04%   64.98%   -0.06%     
==========================================
  Files        1291     1292       +1     
  Lines       17089    17129      +40     
  Branches     2492     2462      -30     
==========================================
+ Hits        11116    11132      +16     
- Misses       5753     5770      +17     
- Partials      220      227       +7     
Flag Coverage Δ
summary 64.98% <32.35%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

bundlemon bot commented Mar 30, 2025

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
324.16KB (+26B +0.01%) +10%
demo/browser/runtime.(hash).js
49.7KB (+24B +0.05%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.81KB +10%
demo/browser/styles.(hash).css
21.17KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +49B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
8.74MB (+10.76KB +0.12%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy enabled auto-merge (squash) April 21, 2025 14:32
@mdlufy mdlufy disabled auto-merge April 21, 2025 14:32
@mdlufy mdlufy force-pushed the expandable-table branch from c46c00e to b540a84 Compare April 21, 2025 14:32
@mdlufy mdlufy enabled auto-merge (squash) April 21, 2025 15:12
@mdlufy mdlufy disabled auto-merge April 21, 2025 15:12
@waterplea waterplea merged commit f8df2a7 into taiga-family:main Apr 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants