Skip to content

fix(kit): navigate to active element after first render for tuiStepper #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

splincode
Copy link
Member

Fixes #10737

@splincode splincode requested a review from a team as a code owner April 9, 2025 11:58
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team April 9, 2025 11:58
Copy link

screenshot-report-bot bot commented Apr 9, 2025

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

nx-cloud bot commented Apr 9, 2025

View your CI Pipeline Execution ↗ for commit 5547bb3.

Command Status Duration Result
nx run-many --target test --all --output-style=... ✅ Succeeded 2m 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-11 13:14:13 UTC

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.09%. Comparing base (67993cb) to head (5547bb3).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...ojects/kit/components/stepper/stepper.component.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10777   +/-   ##
=======================================
  Coverage   65.08%   65.09%           
=======================================
  Files        1283     1283           
  Lines       16960    16960           
  Branches     2448     2459   +11     
=======================================
+ Hits        11039    11040    +1     
+ Misses       5739     5697   -42     
- Partials      182      223   +41     
Flag Coverage Δ
summary 65.09% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Visit the preview URL for this PR (updated for commit 5547bb3):

https://taiga-previews-demo--pr10777-splincode-fix-issues-1073-00zdlp0s.web.app

(expires Sat, 12 Apr 2025 12:58:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Playwright test results

failed  1 failed
passed  1119 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  1121 tests across 74 suites
duration  10 minutes, 42 seconds
commit  5547bb3

Failed tests

chromium › tests/demo/demo.pw.spec.ts › Demo › /navigation/stepper

Skipped tests

chromium › tests/addon-mobile/mobile-dropdown/mobile-dropdown-with-textfield.pw.spec.ts › DropdownMobile for textfields › with select

@splincode splincode force-pushed the splincode/fix/issues/10737 branch from d75f410 to e8972a7 Compare April 11, 2025 07:57
@splincode splincode force-pushed the splincode/fix/issues/10737 branch from e8972a7 to d808a3c Compare April 11, 2025 08:00
@splincode splincode merged commit d45aff8 into main Apr 14, 2025
26 of 27 checks passed
@splincode splincode deleted the splincode/fix/issues/10737 branch April 14, 2025 12:29
aasereb7 pushed a commit to aasereb7/taiga-ui that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Stepper error setting initial index
3 participants